Change all the things #22
Conversation
…ted proxy implementation. Fixes UW-Madison-DoIT#20
… component artifact and json-proxy-service is the fat standalone server
|
To-do:
|
| compile('javax.servlet:javax.servlet-api:3.1.0') { // TODO: was 3.0.1 intentional? | ||
| /* This dependency was originally in the Maven provided scope, but the project was not of type war. | ||
| This behavior is not yet supported by Gradle, so this dependency has been converted to a compile dependency. | ||
| Please review and delete this closure when resolved. */ |
There was a problem hiding this comment.
probably an accident. Is it needed?
There was a problem hiding this comment.
It's a weird and uncharacteristic blind spot that gradle does not have a build in 'provided' scope. Apparently everyone just defines it themselves until gradle comes around, so I updated with that change.
FYI / for reference, 'provided' means a dependency is needed for compilation, but is not meant to be packaged into the final artifact, because that artifact is expected to wind up in a container (e.g. tomcat, jetty) that already has the dependency. Compile often works just as well, but can lead to weird conflicts at runtime.
|
Now this I like, however I want to block it slightly. At the MUM developers meeting, we talked about a few initiatives:
So, I'm going to open some issues for these tasks. We should coordinate a way to order this contribution and the others efficiently. |
|
Good call, @nblair! Should the library be rest-proxy and the service be rest-proxy-service? Or the service called rest-proxy and the library rest-proxy-core? Or something else? I see the '-core' convention in Maven, esp. Spring projects, although maybe this would be inconsistent - it usually seems to refer to a main submodule of an aggregator pom including other plugin submodules. |
…e into boot Includes renaming to rest-proxy, removing deprecated classes, and ticking up version Conflicts: json-proxy-core/src/main/groovy/edu/wisc/my/restproxy/api/GenericRestLookupController.groovy json-proxy-core/src/main/groovy/edu/wisc/my/restproxy/dao/GenericRestLookupDao.groovy json-proxy-core/src/main/groovy/edu/wisc/my/restproxy/dao/GenericRestLookupDaoImpl.groovy json-proxy-core/src/main/groovy/edu/wisc/my/restproxy/service/GenericRestLookupService.groovy json-proxy-core/src/main/groovy/edu/wisc/my/restproxy/service/GenericRestLookupServiceImpl.groovy pom.xml
|
I merged up, renaming the modules to rest-proxy-core and rest-proxy-boot, and ticked up the minor version. |
|
👍 |
|
Okay, I added configuration for the release to nexus and verified by publishing the snapshot: The build cranks out a well-formed pomfile, sources, test, and javadoc artifacts. I'm going to leave it at that and merge if I get another thumb, unless there's more feedback to address. |
| @@ -2,6 +2,7 @@ | |||
| #key.username : the username to login to service (basic auth) * | |||
| #key.password : the password for the service (basic auth) * | |||
| #key.attributes : the csv of attributes | |||
| #key.proxyHeaders : a comma separated list of headers to add output. Can put placeholders for values to get local request attributes. | |||
There was a problem hiding this comment.
Fixed in c1472ee; crisis averted
|
👍 |
My goal was to add a few integration tests to the standalone microservice, but I ran into some issues and basically now I've replaced Maven with Gradle, Java with Groovy, and Grails with Spring Boot.
This PR actually addresses a few issues, though:
There are a couple of (known) TODOs, but I thought I should open a PR for feedback before continuing, since maybe all these changes are not desired, but I wouldn't want to revert something that people find valuable either. Thoughts?